fix: migrate event trigger keying to (eon, identity) - #672
Merged
Conversation
ylembachar
force-pushed
the
fix/update-event-trigger-pk
branch
from
February 24, 2026 15:18
63ea0ec to
3761805
Compare
| return c != nil && | ||
| c.Chain != nil && | ||
| c.Chain.Contracts != nil && | ||
| c.Chain.Contracts.ShutterEventTriggerRegistry != (common.Address{}) |
Contributor
There was a problem hiding this comment.
I am not fully aware of the semantics of the parenthesis around (common.Address{}) here?
Contributor
Author
There was a problem hiding this comment.
They're not needed here.
konradkonrad
approved these changes
Feb 26, 2026
konradkonrad
left a comment
konradkonrad
left a comment
Contributor
There was a problem hiding this comment.
I have one question (see comments), but nothing to complain. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.