Skip to content

Show more information in the retry page #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mperham merged 3 commits into from
May 30, 2013
Merged

Show more information in the retry page #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f162454
show in the retry page any other information added to the job by midd…
rafaelss May 30, 2013
1cb3451
make it possible translate "Extras"
rafaelss May 30, 2013
94d1320
hide "Extras" row if there is nothing to show
rafaelss May 30, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/sidekiq/web.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,20 @@ def display_args(args, count=100)
args.map { |arg| a = arg.inspect; a.size > count ? "#{a[0..count]}..." : a }.join(", ")
end

RETRY_JOB_KEYS = [
"queue", "class", "args", "retry_count", "retried_at", "failed_at",
"retry", "jid", "error_message", "error_class", "backtrace",
"error_backtrace", "unique", "enqueued_at"
]

def retry_extra_items(retry_job)
@retry_extra_items ||= {}.tap do |extra|
retry_job.item.each do |key, value|
extra[key] = value unless RETRY_JOB_KEYS.include?(key)
end
end
end

def tabs
@tabs ||= {
"Dashboard" => '',
Expand Down
1 change: 1 addition & 0 deletions web/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ en: # <---- change this to your locale code
Class: Class
Job: Job
Arguments: Arguments
Extras: Extras
Started: Started
ShowAll: Show All
CurrentMessagesInQueue: Current messages in <span class='title'>%{queue}</span>
Expand Down
1 change: 1 addition & 0 deletions web/locales/pt-br.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
Class: Classe
Job: Tarefa
Arguments: Argumentos
Extras: Extras
Started: Iniciados
ShowAll: Mostrar todos
CurrentMessagesInQueue: Mensagens atualmenta na <span class='title'>%{queue}</span>
Expand Down
5 changes: 5 additions & 0 deletions web/views/retry.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ table class="retry table table-bordered table-striped"
th JID
td
code= @retry.jid
- unless retry_extra_items(@retry).empty?
tr
th = t('Extras')
td
code= display_args(retry_extra_items(@retry), 1000)
- if @retry['retry_count'] > 0
tr
th = t('RetryCount')
Expand Down