[chore][Ansible] Minimal changes for certification (#7271)

* changes requested by ansible certification team

* update requirements.txt for CICD

* can't use name as variable name, rename to item_name

* increase yamllint line length to 150. Longest existing line is 149

* add note about ansible lint

* add newline at end of requirements.yml, remove unnecessary windows requirements

* can't have max version pinned

Author: crobert-1

.github/workflows/ansible.yml

@@ -159,7 +159,7 @@ jobs:
             molecule-plugins[docker]>=25.8.12
             docker>=7.1.0
             requests>=2.32.0
-            urllib3<3
+            urllib3>=2
 
       - name: Set up Python 3.
         uses: actions/setup-python@v6

deployments/ansible_collections/signalfx/splunk_otel_collector/.ansible-lint

@@ -6,5 +6,8 @@ exclude_paths:
   - "molecule/custom_vars/custom_collector_config_deprecated.yml"
   - "molecule/custom_vars_install_old_version/custom_collector_config.yml"
 
+# This is required to be able to double publish the collection to Ansible Galaxy as well as
+# the Ansible Automation Hub. We have the variable rename on the roadmap, but want to ensure
+# we handle it in the smoothest way possible for users. This will be removed in the future.
 skip_list:
   - "var-naming[no-role-prefix]"

deployments/ansible_collections/signalfx/splunk_otel_collector/.yamllint

@@ -4,7 +4,7 @@ extends: default
 
 rules:
   line-length:
-    max: 120
+    max: 150
     level: error
   key-duplicates: enable
   new-lines:

deployments/ansible_collections/signalfx/splunk_otel_collector/CHANGELOG.md

@@ -4,8 +4,6 @@
 
 ### 🛑 Breaking changes 🛑
 
-- Removed support for Ansible 11.X. Minimum supported Ansible version is now 12.2.0. ([#7191](https://github.com/signalfx/splunk-otel-collector/pull/7191))
-
 - Removed support for the following Linux distros ([#7191](https://github.com/signalfx/splunk-otel-collector/pull/7191)):
   - Amazon Linux 2
   - CentOS / Red Hat 8
@@ -16,8 +14,6 @@
 
 ### 💡 Enhancements 💡
 
-- Added support for Ansible 13 ([#7191](https://github.com/signalfx/splunk-otel-collector/pull/7191))
-
 - Added support for the following Linux distros ([#7191](https://github.com/signalfx/splunk-otel-collector/pull/7191)):
   - Debian 12
   - Ubuntu 24.04

deployments/ansible_collections/signalfx/splunk_otel_collector/README.md

@@ -14,7 +14,6 @@ Observability Cloud](https://www.splunk.com/en_us/products/observability.html).
 
 ### Dependencies
 
-- Ansible 12.2.0+
 - Python 3.11+
 
 ### Linux
@@ -94,6 +93,7 @@ if you see something that needs to be improved in this Ansible role.
   please submit a new Splunk Idea. Requires a Splunk.com login.
 - [Splunk Support](https://splunk.my.site.com/customer/s/need-help/create-case) - Ask any question or report any issue
   by opening a support case. Requires Splunk Support entitlement.
+- As Red Hat Ansible Certified Content, this collection is entitled to support through Ansible Automation Platform (AAP). Use the Create issue button on the top right corner of the Automation Hub Collection page for any defects, feature requests, or questions on usage.
 
 ## Release Notes
 

deployments/ansible_collections/signalfx/splunk_otel_collector/galaxy.yml

@@ -28,4 +28,5 @@ tags:
 repository: https://github.com/signalfx/splunk-otel-collector/tree/main/deployments/ansible_collections/signalfx/splunk_otel_collector
 build_ignore:
   - contributing
+  - dist
   - molecule

deployments/ansible_collections/signalfx/splunk_otel_collector/molecule/shared/verify_registry_key.yml

@@ -2,7 +2,7 @@
 - name: Get registry entry
   ansible.windows.win_reg_stat:
     path: "{{ path }}"
-    name: "{{ name }}"
+    name: "{{ item_name }}"
   register: reg_entry
 
 - name: Verify registry entry value

deployments/ansible_collections/signalfx/splunk_otel_collector/molecule/with_instrumentation/windows-verify.yml

@@ -53,6 +53,6 @@
       ansible.builtin.include_tasks: ../shared/verify_registry_key.yml
       vars:
         path: HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager\Environment
-        name: "{{ item.key }}"
+        item_name: "{{ item.key }}"
         exists: false
       loop: "{{ iis_reg_values | dict2items }}"

deployments/ansible_collections/signalfx/splunk_otel_collector/requirements-windows.txt

@@ -1,6 +1 @@
-ansible>=12.2.0
-ansible-compat<=25.8.2
-ansible-lint<=26.1.1
-molecule<=25.1.0
-molecule-plugins[vagrant]<=25.8.12
-pywinrm<=0.4.3
+pywinrm>=0.4.0

deployments/ansible_collections/signalfx/splunk_otel_collector/requirements.txt

@@ -1,7 +1,3 @@
-ansible>=12.2.0
-ansible-lint>=26.1.0
-molecule>=25.5.0
-molecule-plugins[docker]>=25.8.12
 docker>=7.1.0
 requests>=2.32.0
-urllib3<3
+urllib3>=2