Update to use the ballast memory instead of the flag#567
Merged
rmfitzpatrick merged 1 commit intosignalfx:mainfrom Jul 23, 2021
bogdandrutu:membalast
Merged
Update to use the ballast memory instead of the flag#567rmfitzpatrick merged 1 commit intosignalfx:mainfrom bogdandrutu:membalast
rmfitzpatrick merged 1 commit intosignalfx:mainfrom
bogdandrutu:membalast
Conversation
Contributor
bogdandrutu
commented
Jul 22, 2021
bogdandrutu
commented
- The memory_ballast extension is the only way to configure ballast starting with v0.31.0 of the collector;
- The memory_limiter processor accesses the ballast directly from the config, no need to set ballast_memory_size anymore;
tigrannajaryan
approved these changes
Jul 22, 2021
Contributor
Author
|
@tigrannajaryan I extracted the upgrade in a separate PR that this PR depends on #568 |
* The memory_ballast extension is the only way to configure ballast starting with v0.31.0 of the collector; * The memory_limiter processor accesses the ballast directly from the config, no need to set ballast_memory_size anymore; Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Contributor
Author
|
@tigrannajaryan I had to re-write the tests to make sure I am not breaking anything :) |
tigrannajaryan
approved these changes
Jul 23, 2021
Contributor
|
Looks like I don't have merging rights. |
Contributor
Author
|
@tigrannajaryan not even approving rights :)) |
rmfitzpatrick
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.