Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the migratecheckpoint command and related files following the deprecation of the fluentd sidecar. The migration tool is no longer needed since users are no longer transitioning from fluentd to the OpenTelemetry Collector.
Key changes:
- Removed the entire
migratecheckpointcommand implementation and tests - Updated build scripts and CI/CD configurations to exclude
migratecheckpointbinary generation - Removed documentation references to the migration tool
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/migratecheckpoint/main.go | Removed main implementation of the checkpoint migration tool |
| cmd/migratecheckpoint/main_test.go | Removed test cases for checkpoint migration functionality |
| cmd/migratecheckpoint/log_library.go | Removed supporting library code for log file operations |
| cmd/migratecheckpoint/filestorage.go | Removed file storage client implementation |
| cmd/migratecheckpoint/README.md | Removed documentation for the migration tool |
| docs/deprecations/fluentd-support.md | Removed references to the migration tool from deprecation documentation |
| cmd/otelcol/Dockerfile | Removed migratecheckpoint binary from Docker image |
| packaging/docker-otelcol.sh | Removed migratecheckpoint from build artifacts list |
| Makefile | Removed migratecheckpoint build targets and commands |
| .gitlab-ci.yml | Removed migratecheckpoint artifacts from CI pipeline |
| .chloggen/remove-migratecheckpoint.yaml | Added changelog entry documenting the breaking change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (37.95%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6881 +/- ##
==========================================
+ Coverage 37.78% 37.95% +0.16%
==========================================
Files 370 367 -3
Lines 25925 25739 -186
==========================================
- Hits 9797 9770 -27
+ Misses 15308 15159 -149
+ Partials 820 810 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfb8637 to
a2f45ff
Compare
The migratecheckpoint command is no longer needed following the deprecation of the fluentd sidecar in the helm chart.
a2f45ff to
47a7bd6
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The migratecheckpoint command is no longer needed following the deprecation of the fluentd sidecar in signalfx/splunk-otel-collector-chart#2138