Skip to content

Remove migratecheckpoint command#6881

Merged
dmitryax merged 1 commit intomainfrom
remove-migrate-checkpoint
Oct 29, 2025
Merged

Remove migratecheckpoint command#6881
dmitryax merged 1 commit intomainfrom
remove-migrate-checkpoint

Conversation

@dmitryax
Copy link
Contributor

The migratecheckpoint command is no longer needed following the deprecation of the fluentd sidecar in signalfx/splunk-otel-collector-chart#2138

@dmitryax dmitryax requested a review from a team as a code owner October 28, 2025 18:27
Copilot AI review requested due to automatic review settings October 28, 2025 18:27
@dmitryax dmitryax requested review from a team as code owners October 28, 2025 18:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the migratecheckpoint command and related files following the deprecation of the fluentd sidecar. The migration tool is no longer needed since users are no longer transitioning from fluentd to the OpenTelemetry Collector.

Key changes:

  • Removed the entire migratecheckpoint command implementation and tests
  • Updated build scripts and CI/CD configurations to exclude migratecheckpoint binary generation
  • Removed documentation references to the migration tool

Reviewed Changes

Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cmd/migratecheckpoint/main.go Removed main implementation of the checkpoint migration tool
cmd/migratecheckpoint/main_test.go Removed test cases for checkpoint migration functionality
cmd/migratecheckpoint/log_library.go Removed supporting library code for log file operations
cmd/migratecheckpoint/filestorage.go Removed file storage client implementation
cmd/migratecheckpoint/README.md Removed documentation for the migration tool
docs/deprecations/fluentd-support.md Removed references to the migration tool from deprecation documentation
cmd/otelcol/Dockerfile Removed migratecheckpoint binary from Docker image
packaging/docker-otelcol.sh Removed migratecheckpoint from build artifacts list
Makefile Removed migratecheckpoint build targets and commands
.gitlab-ci.yml Removed migratecheckpoint artifacts from CI pipeline
.chloggen/remove-migratecheckpoint.yaml Added changelog entry documenting the breaking change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.95%. Comparing base (2339b2c) to head (47a7bd6).

❌ Your project check has failed because the head coverage (37.95%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6881      +/-   ##
==========================================
+ Coverage   37.78%   37.95%   +0.16%     
==========================================
  Files         370      367       -3     
  Lines       25925    25739     -186     
==========================================
- Hits         9797     9770      -27     
+ Misses      15308    15159     -149     
+ Partials      820      810      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmitryax dmitryax force-pushed the remove-migrate-checkpoint branch from cfb8637 to a2f45ff Compare October 28, 2025 18:38
The migratecheckpoint command is no longer needed following the deprecation of the fluentd sidecar in the helm chart.
Copilot AI review requested due to automatic review settings October 28, 2025 19:44
@dmitryax dmitryax force-pushed the remove-migrate-checkpoint branch from a2f45ff to 47a7bd6 Compare October 28, 2025 19:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 12 out of 15 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dmitryax dmitryax merged commit 35864e8 into main Oct 29, 2025
241 of 243 checks passed
@dmitryax dmitryax deleted the remove-migrate-checkpoint branch October 29, 2025 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants