Skip to content

Deprecate collectd-zookeeper#7016

Merged
pjanotti merged 3 commits intomainfrom
deprecate-zookeeper-collectd-monitor
Dec 12, 2025
Merged

Deprecate collectd-zookeeper#7016
pjanotti merged 3 commits intomainfrom
deprecate-zookeeper-collectd-monitor

Conversation

@pjanotti
Copy link
Contributor

Deprecate the collectd-zookeeper plugin.

Copilot AI review requested due to automatic review settings December 12, 2025 21:54
@pjanotti pjanotti requested review from a team as code owners December 12, 2025 21:54
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.84%. Comparing base (f8c0991) to head (3a64755).

Files with missing lines Patch % Lines
...agent/pkg/monitors/collectd/zookeeper/zookeeper.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7016      +/-   ##
==========================================
+ Coverage   37.83%   37.84%   +0.01%     
==========================================
  Files         366      366              
  Lines       25618    25619       +1     
==========================================
+ Hits         9692     9696       +4     
+ Misses      15115    15114       -1     
+ Partials      811      809       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deprecates the collectd/zookeeper plugin with a planned removal date of the end of March 2026, directing users to migrate to the upstream zookeeper receiver from opentelemetry-collector-contrib. The deprecation follows the established pattern used for other collectd plugin deprecations in this codebase.

  • Adds runtime deprecation warning when the plugin is configured
  • Updates documentation to inform users about the deprecation
  • Creates a changelog entry for the deprecation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/signalfx-agent/pkg/monitors/collectd/zookeeper/zookeeper.go Adds warning log in the Configure method to notify users about deprecation and removal timeline
internal/signalfx-agent/pkg/monitors/collectd/zookeeper/metadata.yaml Updates documentation with bold deprecation notice at the top of the description
.chloggen/deprecate-collectd-zookeeper-monitor.yaml Creates changelog entry for the deprecation announcement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 12, 2025 22:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pjanotti pjanotti merged commit 7ad3640 into main Dec 12, 2025
236 of 237 checks passed
@pjanotti pjanotti deleted the deprecate-zookeeper-collectd-monitor branch December 12, 2025 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants