Remove SignalFx monitor windows-legacy#7098
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated SignalFx Smart Agent monitor windows-legacy from the embedded signalfx-agent code and documents the breaking change.
Changes:
- Deleted the
windowslegacymonitor implementation and its generated metadata. - Removed the monitor’s module registration import from the core module import list.
- Added a breaking-change changelog entry directing users to supported alternatives.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/signalfx-agent/pkg/monitors/windowslegacy/windowslegacy_windows.go | Removes the Windows implementation of the deprecated windows-legacy monitor. |
| internal/signalfx-agent/pkg/monitors/windowslegacy/windowslegacy_other.go | Removes the non-Windows stub implementation for the deprecated monitor. |
| internal/signalfx-agent/pkg/monitors/windowslegacy/windowslegacy.go | Removes monitor registration/config/shutdown glue code. |
| internal/signalfx-agent/pkg/monitors/windowslegacy/metadata.yaml | Removes monitor metadata/documentation source. |
| internal/signalfx-agent/pkg/monitors/windowslegacy/genmetadata.go | Removes generated monitor metadata used by the agent. |
| internal/signalfx-agent/pkg/core/modules.go | Drops the blank import that registered windowslegacy. |
| .chloggen/remove_signalfx_smartagent_windows-legacy.yaml | Adds release-note entry documenting the breaking removal and migration path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7098 +/- ##
=======================================
Coverage 38.86% 38.87%
=======================================
Files 348 346 -2
Lines 24246 24238 -8
=======================================
- Hits 9423 9422 -1
+ Misses 14041 14035 -6
+ Partials 782 781 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crobert-1
approved these changes
Jan 23, 2026
atoulme
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove already deprecated legacy monitor
windows-legacy.