Skip to content

[includeconfigsource] deprecate delete_files setting#7141

Merged
atoulme merged 2 commits intomainfrom
deprecate_delete_files
Jan 31, 2026
Merged

[includeconfigsource] deprecate delete_files setting#7141
atoulme merged 2 commits intomainfrom
deprecate_delete_files

Conversation

@atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 31, 2026

Description:
Deprecate the delete_files setting. This makes the includeconfigsource stateless, removing a feature that is no longer desirable to support. It will be removed on or after April 2026.

@atoulme atoulme requested review from a team as code owners January 31, 2026 01:41
@atoulme atoulme force-pushed the deprecate_delete_files branch 2 times, most recently from f64ea0c to d44478a Compare January 31, 2026 01:54
@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.21%. Comparing base (985c37c) to head (d313ec5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/configsource/includeconfigsource/source.go 16.66% 2 Missing and 3 partials ⚠️

❌ Your project check has failed because the head coverage (33.21%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7141      +/-   ##
==========================================
- Coverage   33.22%   33.21%   -0.01%     
==========================================
  Files         330      330              
  Lines       23321    23328       +7     
==========================================
  Hits         7748     7748              
- Misses      14678    14684       +6     
- Partials      895      896       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atoulme atoulme force-pushed the deprecate_delete_files branch from d44478a to d313ec5 Compare January 31, 2026 02:09
@atoulme atoulme merged commit 173bce6 into main Jan 31, 2026
@atoulme atoulme deleted the deprecate_delete_files branch January 31, 2026 03:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants