Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the packaging test infrastructure and installer gating logic to recognize and exercise EL10-family distributions.
Changes:
- Added new RPM test container images for CentOS Stream 10, Oracle Linux 10, and Rocky Linux 10.
- Updated the Linux installer’s distro support check to accept major version 10 for
centos|ol|rhel|rocky. - Added a changelog entry documenting EL10 support.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packaging/tests/images/rpm/Dockerfile.rockylinux-10 | Adds a Rocky Linux 10 systemd-enabled test image. |
| packaging/tests/images/rpm/Dockerfile.oraclelinux-10 | Adds an Oracle Linux 10 systemd-enabled test image. |
| packaging/tests/images/rpm/Dockerfile.centos-10 | Adds a CentOS Stream 10 systemd-enabled test image. |
| packaging/installer/install.sh | Extends supported EL major versions to include 10. |
| .chloggen/RHEL-10.yaml | Records the enhancement in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,21 @@ | |||
| # A centos9 image with systemd enabled. Must be run with: | |||
There was a problem hiding this comment.
The header comment says this is a centos9 image, but the base image is CentOS Stream 10. Update the comment to the correct version to avoid confusion.
| # A centos9 image with systemd enabled. Must be run with: | |
| # A CentOS Stream 10 image with systemd enabled. Must be run with: |
| # A centos9 image with systemd enabled. Must be run with: | ||
| # `-d --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:ro` flags | ||
| FROM quay.io/centos/centos:stream10 |
There was a problem hiding this comment.
PR title/description indicate RHEL/Oracle/Rocky 10 support, but this change also adds a CentOS Stream 10 test image. Either update the PR title/description to include CentOS Stream 10 or drop this Dockerfile if it’s out of scope.
| # A oraclelinux9 image with systemd enabled. Must be run with: | ||
| # `-d --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:ro` flags | ||
| FROM oraclelinux:10 |
There was a problem hiding this comment.
Adding a new Dockerfile.* under packaging/tests/images/rpm automatically adds a new entry to RPM_DISTROS (derived via glob) and will expand parametrized test matrices. Ensure the deployment-specific test images (e.g., packaging/tests/deployments/puppet/images/rpm/Dockerfile.) also include this distro or that tests explicitly skip it; otherwise those tests will fail when they try to locate a matching Dockerfile.
| # A rockylinux9 image with systemd enabled. Must be run with: | ||
| # `-d --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:ro` flags | ||
| FROM quay.io/rockylinux/rockylinux:10 |
There was a problem hiding this comment.
Adding a new Dockerfile.* under packaging/tests/images/rpm automatically adds a new entry to RPM_DISTROS (derived via glob) and will expand parametrized test matrices. Ensure the deployment-specific test images (e.g., packaging/tests/deployments/puppet/images/rpm/Dockerfile.) also include this distro or that tests explicitly skip it; otherwise those tests will fail when they try to locate a matching Dockerfile.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (33.18%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7195 +/- ##
==========================================
- Coverage 33.22% 33.18% -0.04%
==========================================
Files 330 330
Lines 23350 23350
==========================================
- Hits 7758 7749 -9
- Misses 14698 14704 +6
- Partials 894 897 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Dani Louca <dlouca@splunk.com>
Signed-off-by: Dani Louca <dlouca@splunk.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description:
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: