adds examples of signing with other tools#123
Conversation
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
Sections on GCP KMS and AWS KMS LGTM, we can omit the section on openssl since it's already covered
ltagliaferri
left a comment
ltagliaferri
left a comment
There was a problem hiding this comment.
Thank you for this! I just have a few little copyedits
content/en/cosign/sign.md
Outdated
| Sign the payload with `gcloud kms`: | ||
|
|
||
| ```shell | ||
| $ gcloud kms asymmetric-sign --digest-algorithm=sha256 --input-file=payload.json --signature-file=gcpkms.sig --key=foo --keyring=foo --version=1 --location=us-central |
There was a problem hiding this comment.
Can you break this onto more than one line so it's easier for the reader (that is, so that they don't need to scroll horizontally)
There was a problem hiding this comment.
yep, just pushed up the change
content/en/cosign/sign.md
Outdated
| Base64 encode the signature and upload with `cosign`: | ||
|
|
||
| ```shell | ||
| cat gcpkms.sig | base64 | cosign attach signature --payload payload.json --signature - us-central1-docker.pkg.dev/dlorenc-vmtest2/test/taskrun |
There was a problem hiding this comment.
I would break this onto two lines too, and be more generic, like:
us-central1-docker.pkg.dev/user/test/taskrun
There was a problem hiding this comment.
yep, just pushed up the change. i noticed some others too which I've changed to be generic
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
ChrisJBurns
force-pushed
the
adds-other-examples-in-signing-docs
branch
from
a33d05d to
d1f879d
Compare
3 participants
This aims to deprecate https://github.com/sigstore/cosign/blob/main/EXAMPLES.md
Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com