Skip to content

enhancement: deprecate LMS and LM-OTS#597

Merged
Hayden-IO merged 2 commits intosigstore:mainfrom
arthurus-rex:main
Apr 14, 2025
Merged

enhancement: deprecate LMS and LM-OTS#597
Hayden-IO merged 2 commits intosigstore:mainfrom
arthurus-rex:main

Conversation

@arthurus-rex
Copy link
Copy Markdown
Contributor

From Issue #591 due to potential for misuse and changes to NIST recommendations.

Summary

Resolves issue #591

Release Note

Documentation

From Issue sigstore#591 due to potential for misuse and changes
to NIST recommendations.

Signed-off-by: Arthur Savage <asavage@redhat.com>
woodruffw
woodruffw previously approved these changes Apr 11, 2025
@woodruffw
Copy link
Copy Markdown
Member

Thanks @arthurus-rex! BTW you'll probably need to run make all and check the resulting changes in, since docstring changes propagate to the codegen as well.

@arthurus-rex
Copy link
Copy Markdown
Contributor Author

I tried to run make all on both my changes and the current sigstore/protobuf-specs, and I get similar errors:

=> [protoc-builder 3/9] RUN apt-get update && apt-get install -y unzip git                                                                             7.1s
 => ERROR [protoc-builder 4/9] RUN adduser --uid 0 --disabled-password myuser                                                                           0.2s 
------                                                                                                                                                       
 > [protoc-builder 4/9] RUN adduser --uid 0 --disabled-password myuser:                                                                                      
0.145 adduser: The UID 0 is already in use.                                                                                                                  
------                                                                                                                                                       
Dockerfile.protoc:15                                                                                                                                         
--------------------
  13 |     ARG UID
  14 |     
  15 | >>> RUN adduser --uid ${UID} --disabled-password myuser
  16 |     
  17 |     # Set permissions on the output directories so the user can write to them
--------------------
ERROR: failed to solve: process "/bin/sh -c adduser --uid ${UID} --disabled-password myuser" did not complete successfully: exit code: 1
make: *** [Makefile:90: base-image-go] Error 1

Any idea what might be wrong? If this isn't some problem with how I've configured my local machine, I can make an issue.

@woodruffw
Copy link
Copy Markdown
Member

Huh, I wonder if that's a Docker version thing. What version are you running?

(Yeah, I think it makes sense to file an issue for this -- I can also push the schema changes up to your branch to unblock things here.)

Signed-off-by: William Woodruff <william@trailofbits.com>
@arthurus-rex
Copy link
Copy Markdown
Contributor Author

My version is Docker version 28.0.4, build b8034c0, and I did a clean install already just in case. And yes, I'd appreciate you do that, thank you. I'll file the issue.

@Hayden-IO Hayden-IO merged commit 4c08c80 into sigstore:main Apr 14, 2025
22 checks passed
arthurus-rex added a commit to arthurus-rex/protobuf-specs that referenced this pull request Apr 14, 2025
* enhancement: deprecate LMS and LM-OTS

From Issue sigstore#591 due to potential for misuse and changes
to NIST recommendations.

Signed-off-by: Arthur Savage <asavage@redhat.com>

* gen: `make all`

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: Arthur Savage <asavage@redhat.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Co-authored-by: Arthur Savage <asavage@redhat.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
arthurus-rex added a commit to arthurus-rex/protobuf-specs that referenced this pull request Apr 14, 2025
* enhancement: deprecate LMS and LM-OTS

From Issue sigstore#591 due to potential for misuse and changes
to NIST recommendations.

Signed-off-by: Arthur Savage <asavage@redhat.com>

* gen: `make all`

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: Arthur Savage <asavage@redhat.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Co-authored-by: Arthur Savage <asavage@redhat.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants