Skip to content

Move createEntryRequest into entry.proto#340

Merged
loosebazooka merged 1 commit intomainfrom
move-entry-request
Jun 6, 2025
Merged

Move createEntryRequest into entry.proto#340
loosebazooka merged 1 commit intomainfrom
move-entry-request

Conversation

@loosebazooka
Copy link
Copy Markdown
Member

Should allow the request type to be populated as a proto type. handles: sigstore/protobuf-specs#661 (comment)

Signed-off-by: Appu Goundan <appu@google.com>
@loosebazooka loosebazooka requested review from Hayden-IO and jku June 6, 2025 14:11
@loosebazooka loosebazooka requested review from a team as code owners June 6, 2025 14:11
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 38.06%. Comparing base (4086878) to head (2fb43aa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generated/protobuf/entry.pb.go 0.00% 43 Missing ⚠️
pkg/generated/protobuf/rekor_service.pb.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   38.05%   38.06%   +0.01%     
==========================================
  Files          41       41              
  Lines        2959     2958       -1     
==========================================
  Hits         1126     1126              
+ Misses       1728     1727       -1     
  Partials      105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@loosebazooka
Copy link
Copy Markdown
Member Author

@haydentherapper sorry can we do another tag after this?

@loosebazooka loosebazooka merged commit 62134b5 into main Jun 6, 2025
13 checks passed
@loosebazooka loosebazooka deleted the move-entry-request branch June 6, 2025 14:51
@Hayden-IO
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants