Adds new rekor metrics for latency and QPS.#1059
Merged
bobcallaway merged 2 commits intosigstore:mainfrom Sep 20, 2022
var-sdk:fix-metrics
Merged
Adds new rekor metrics for latency and QPS.#1059bobcallaway merged 2 commits intosigstore:mainfrom var-sdk:fix-metrics
bobcallaway merged 2 commits intosigstore:mainfrom
var-sdk:fix-metrics
Conversation
added 2 commits
September 19, 2022 17:25
Signed-off-by: Simon Kent <simek@google.com>
Signed-off-by: Simon Kent <simek@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 41.02% 41.02%
=======================================
Files 71 71
Lines 7061 7061
=======================================
Hits 2897 2897
Misses 3858 3858
Partials 306 306 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bobcallaway
approved these changes
Sep 20, 2022
Member
bobcallaway
left a comment
There was a problem hiding this comment.
lgtm, thanks for doing this!
dlorenc
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current server metrics have two problems:
The two new metrics track latency by endpoint/method, and qps by endpoint/method/status code for error budget. The old metrics will be removed once monitoring has been updated to use the new metrics.
Summary
Release Note
Documentation