Skip to content

update boilerplate header and apply go fmt#275

Merged
dlorenc merged 3 commits intosigstore:mainfrom
cpanato:add-licenses
Apr 15, 2021
Merged

update boilerplate header and apply go fmt#275
dlorenc merged 3 commits intosigstore:mainfrom
cpanato:add-licenses

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Apr 15, 2021

  • make all boilerplate header similar to each other
  • update some go formating code
  • add ci verify to validate the boilerplates
  • add golangci-lint rules

sorry, big PR :(

more context slack 🧵 : https://sigstore.slack.com/archives/C01CQ3L3H8X/p1617957935102100

/assign @dlorenc @lukehinds

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Copy link
Copy Markdown
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good, just a couple comments

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Copy link
Copy Markdown
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @cpanato

@dlorenc dlorenc merged commit b073175 into sigstore:main Apr 15, 2021
@cpanato cpanato deleted the add-licenses branch April 15, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants