return correct errors in rare failure situations#2753
Merged
bobcallaway merged 1 commit intosigstore:mainfrom Feb 17, 2026
Merged
return correct errors in rare failure situations#2753bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway merged 1 commit intosigstore:mainfrom
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
===========================================
- Coverage 66.46% 26.17% -40.29%
===========================================
Files 92 191 +99
Lines 9258 20127 +10869
===========================================
- Hits 6153 5269 -884
- Misses 2359 14030 +11671
- Partials 746 828 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cpanato
approved these changes
Feb 17, 2026
Hayden-IO
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while analyzing the codebase, I noticed in three situations that we would return an incorrect err which would make debugging more challenging. this returns the correct err in each situation.