Skip to content

return correct errors in rare failure situations#2753

Merged
bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway:return_err
Feb 17, 2026
Merged

return correct errors in rare failure situations#2753
bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway:return_err

Conversation

@bobcallaway
Copy link
Member

while analyzing the codebase, I noticed in three situations that we would return an incorrect err which would make debugging more challenging. this returns the correct err in each situation.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner February 17, 2026 12:42
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.17%. Comparing base (488eb97) to head (7caa1f4).
⚠️ Report is 636 commits behind head on main.

Files with missing lines Patch % Lines
pkg/trillianclient/trillian_client.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2753       +/-   ##
===========================================
- Coverage   66.46%   26.17%   -40.29%     
===========================================
  Files          92      191       +99     
  Lines        9258    20127    +10869     
===========================================
- Hits         6153     5269      -884     
- Misses       2359    14030    +11671     
- Partials      746      828       +82     
Flag Coverage Δ
e2etests 49.50% <0.00%> (+1.94%) ⬆️
unittests 16.72% <20.00%> (-30.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobcallaway bobcallaway merged commit 6de110d into sigstore:main Feb 17, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants