Type assert the entry bundle when verifying inclusion proof#2755
Merged
Hayden-IO merged 2 commits intosigstore:mainfrom Mar 3, 2026
Merged
Type assert the entry bundle when verifying inclusion proof#2755Hayden-IO merged 2 commits intosigstore:mainfrom
Hayden-IO merged 2 commits intosigstore:mainfrom
Conversation
This guards against a body unexpectedly being a different type. Signed-off-by: Hayden <8418760+Hayden-IO@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
===========================================
- Coverage 66.46% 26.18% -40.28%
===========================================
Files 92 191 +99
Lines 9258 20132 +10874
===========================================
- Hits 6153 5272 -881
- Misses 2359 14031 +11672
- Partials 746 829 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bobcallaway
reviewed
Feb 17, 2026
bobcallaway
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This guards against a body unexpectedly being a different type.
Thanks to @1seal for reporting this.
Summary
Release Note
Documentation