Merged
Conversation
dlorenc
force-pushed
the
storage
branch
4 times, most recently
from
0aca0a4 to
70ffb41
Compare
dlorenc
force-pushed
the
storage
branch
11 times, most recently
from
01b7c59 to
010daaa
Compare
This adds an "Attestation" method to the entry interface. Entries can return an attestation that they would like to store. The attestations are currently stored in GCS, but it supports any blob store. The feature is turned off with a flag, and we can set a max size as well. Signed-off-by: Dan Lorenc <dlorenc@google.com>
bobcallaway
approved these changes
Jun 7, 2021
Member
bobcallaway
left a comment
bobcallaway
left a comment
There was a problem hiding this comment.
one question, but LGTM otherwise
| uuid := getUUIDFromUploadOutput(t, out) | ||
|
|
||
| // The atteestation should be stored at /var/run/attestations/$uuid | ||
| cmd := exec.Command("docker", "run", "-v", "/var/run/attestations:/var/run/attestations", "alpine", "cat", "/var/run/attestations/"+uuid) |
Member
There was a problem hiding this comment.
could this be simplified to just read directly from /var/run/attestations/ on the host?
Member
Author
There was a problem hiding this comment.
Not always, especially in CI you're typically running in a container too with the docker socket mounted in.
It's the same roughly for Mac or anywhere that you have docker in a VM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an "Attestation" method to the entry interface. Entries can
return an attestation that they would like to store.
The attestations are currently stored in GCS, but it supports any blob store.
The feature is turned off with a flag, and we can set a max size as well.
TODO:
Signed-off-by: Dan Lorenc dlorenc@google.com