Update snippets to use console type for snippets#410
Merged
dlorenc merged 1 commit intosigstore:mainfrom Aug 13, 2021
Merged
Conversation
Member
|
Whoa! I had no idea this was a thing! |
Contributor
Author
|
Me neither until 5 minutes ago! I was reading the readme and thought that there must be a proper way of highlighting those snippets, and finally ended up on https://github.com/github/linguist/blob/7efa7b3380ad0221c499f9ef1ca84c4dfcc0b299/lib/linguist/languages.yml#L5594-L5605 , which works! BTW the DCO is complaining that my commit (which I authored from the web UI) is not signed..... I guess I need to do a proper one from my laptop and force push. I must say I don't really understand what signing commits actually buys you though. |
Member
|
@tiziano88 thanks for the PR |
`shell` or `bash` expects the entire snippet to be a bash script, while `console` highlights only lines prefixed with `$` as bash. Signed-off-by: Tiziano Santoro <tiziano88@gmail.com>
Contributor
Author
|
Done now. |
dlorenc
approved these changes
Aug 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shellorbashexpects the entire snippet to be a bash script, whileconsolehighlights only lines prefixed with$as bash.