Add index to hashed intoto envelope#761
Merged
dlorenc merged 2 commits intosigstore:mainfrom Apr 8, 2022
Merged
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Codecov Report
@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 49.15% 49.04% -0.11%
==========================================
Files 61 61
Lines 5566 5574 +8
==========================================
- Hits 2736 2734 -2
- Misses 2536 2545 +9
- Partials 294 295 +1
Continue to review full report at Codecov.
|
bobcallaway
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Summary
Ticket Link
Related #646
This allows searching for a rekor entry by the signed envelope hash. E.g. if a user has
provenance.intoto.jsonl, then currently we can't search for that provenance unless we take the hash of the payload or Subject.Digest's. This way cosign will also verify-blob the hard way by searching for the artifact file hash.The hash is the same as the hash in the rekor entry:
Release Note