Fix indexing bug for intoto attestations#870
Merged
dlorenc merged 1 commit intosigstore:mainfrom Jun 15, 2022
Merged
Conversation
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 46.24% 46.34% +0.10%
==========================================
Files 60 60
Lines 5138 5135 -3
==========================================
+ Hits 2376 2380 +4
+ Misses 2487 2482 -5
+ Partials 275 273 -2
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Jun 15, 2022
bobcallaway
approved these changes
Jun 15, 2022
Contributor
|
Again, the root cause is because we index on pre-canonicalized entries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
IntotoObj.Contentfield isn't specified, we end up returning too soon instead of adding provenance subject digests as indexing keys.cosign attestnever sets the Content field, so searching for attestations uploaded with cosign isn't working.This should fix it and adds in a unit test.
Signed-off-by: Priya Wadhwa priya@chainguard.dev