Skip to content

Fix indexing bug for intoto attestations#870

Merged
dlorenc merged 1 commit intosigstore:mainfrom
priyawadhwa:return-attestation
Jun 15, 2022
Merged

Fix indexing bug for intoto attestations#870
dlorenc merged 1 commit intosigstore:mainfrom
priyawadhwa:return-attestation

Conversation

@priyawadhwa
Copy link
Contributor

If the IntotoObj.Content field isn't specified, we end up returning too soon instead of adding provenance subject digests as indexing keys. cosign attest never sets the Content field, so searching for attestations uploaded with cosign isn't working.

This should fix it and adds in a unit test.

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa requested a review from bobcallaway as a code owner June 15, 2022 10:59
@codecov-commenter
Copy link

Codecov Report

Merging #870 (d3a2144) into main (45da1af) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   46.24%   46.34%   +0.10%     
==========================================
  Files          60       60              
  Lines        5138     5135       -3     
==========================================
+ Hits         2376     2380       +4     
+ Misses       2487     2482       -5     
+ Partials      275      273       -2     
Impacted Files Coverage Δ
pkg/types/intoto/v0.0.1/entry.go 36.74% <100.00%> (+0.96%) ⬆️
pkg/types/alpine/v0.0.1/entry.go 55.78% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45da1af...d3a2144. Read the comment docs.

@dlorenc dlorenc merged commit 744339f into sigstore:main Jun 15, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jun 15, 2022
@asraa
Copy link
Contributor

asraa commented Jun 15, 2022

Again, the root cause is because we index on pre-canonicalized entries.
#854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants