Check inactive shards for UUID for /retrieve endpoint#905
Merged
dlorenc merged 2 commits intosigstore:mainfrom Jul 6, 2022
Merged
Check inactive shards for UUID for /retrieve endpoint#905dlorenc merged 2 commits intosigstore:mainfrom
dlorenc merged 2 commits intosigstore:mainfrom
Conversation
priyawadhwa
force-pushed
the
retrieve-inactive-bug
branch
from
3541ef9 to
16a430d
Compare
dlorenc
previously approved these changes
Jul 5, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
force-pushed
the
retrieve-inactive-bug
branch
from
16a430d to
69e6d64
Compare
bobcallaway
reviewed
Jul 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 47.86% 47.72% -0.15%
==========================================
Files 62 62
Lines 5461 5461
==========================================
- Hits 2614 2606 -8
- Misses 2559 2565 +6
- Partials 288 290 +2
Continue to review full report at Codecov.
|
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
force-pushed
the
retrieve-inactive-bug
branch
from
a140b43 to
0367027
Compare
Contributor
Author
|
Thanks for the review @bobcallaway, addressed all comments! |
bobcallaway
approved these changes
Jul 6, 2022
dlorenc
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the logic for finding a UUID into a separate function so that get and retrieve can both use it
Fixes #899
Signed-off-by: Priya Wadhwa priya@chainguard.dev
Summary
Release Note
Documentation