Merged
Conversation
…versions Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
cpanato
approved these changes
Jul 29, 2022
dlorenc
approved these changes
Aug 2, 2022
bobcallaway
reviewed
Aug 2, 2022
Member
bobcallaway
left a comment
bobcallaway
left a comment
There was a problem hiding this comment.
lgtm, one question regarding the logic
bobcallaway
approved these changes
Aug 2, 2022
Contributor
Author
|
thanks for the reviews! i don't think i have write access, could someone merge this for me? 😄 |
bobcallaway
pushed a commit
to bobcallaway/rekor
that referenced
this pull request
Aug 3, 2022
…versions (sigstore#945) Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in tests specifically for the test harness. Instead of running tests we already have, the harness will run specific tests:
TestHarnessAddEntry-- adds in the standard HashedRekord typeTestHarnessAddIntoto-- adds in an intoto attestationTestHarnessGetAllEntriesLogIndex-- makes sure the current combo of rekor-server/rekor-cli can get every entry in the log by log index. If the entry is an attestation, confirms that the "Attestation" field is not empty.We still test against the 3 most recent versions of the server, against the 3 most recent versions of the CLI. We start the server, run the tests, and then upgrade. At the end, we make sure there are 18 entries in the log as expected.
TODO: We want to make sure that getting entries by UUID/EntryID will also work. Will add that in an upcoming PR.
cc @bobcallaway