Skip to content

Fix platform bugs #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sigurdm merged 1 commit into from
Nov 29, 2017
Merged

Fix platform bugs #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/video_player/android/src/main/java/io/flutter/videoplayer/VideoPlayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ private class VideoPlayer {
private final EventChannel eventChannel;
private boolean isPlaying = false;
private boolean isInitialized = false;
private boolean isLooping = false;

@TargetApi(21)
VideoPlayer(
Expand Down Expand Up @@ -133,7 +132,7 @@ void pause() {
}

void setLooping(boolean value) {
mediaPlayer.setLooping(isLooping);
mediaPlayer.setLooping(value);
}

void setVolume(double value) {
Expand Down
3 changes: 2 additions & 1 deletion packages/video_player/ios/Classes/VideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ - (instancetype)initWithURL:(NSURL*)url frameUpdater:(FrameUpdater*)frameUpdater
if ([videoTrack statusOfValueForKey:@"preferredTransform" error:nil] ==
AVKeyValueStatusLoaded) {
dispatch_async(dispatch_get_main_queue(), ^{
[item addOutput:_videoOutput];
[_player replaceCurrentItemWithPlayerItem:item];
});
}
Expand Down Expand Up @@ -147,6 +146,7 @@ - (void)observeValueForKeyPath:(NSString*)path
break;
case AVPlayerItemStatusReadyToPlay:
_isInitialized = true;
[item addOutput:_videoOutput];
[self sendInitialized];
[self updatePlayingState];
break;
Expand Down Expand Up @@ -230,6 +230,7 @@ - (FlutterError* _Nullable)onListenWithArguments:(id _Nullable)arguments

- (void)dispose {
_disposed = true;
[_displayLink invalidate];
[[_player currentItem] removeObserver:self forKeyPath:@"status" context:statusContext];
[[_player currentItem] removeObserver:self
forKeyPath:@"loadedTimeRanges"
Expand Down