Skip to content

Fix lint warnings#9

Merged
sile merged 4 commits into
masterfrom
fix-lint
May 5, 2025
Merged

Fix lint warnings#9
sile merged 4 commits into
masterfrom
fix-lint

Conversation

@sile
Copy link
Copy Markdown
Owner

@sile sile commented May 5, 2025

No description provided.

@sile sile requested a review from Copilot May 5, 2025 10:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several lint warnings by simplifying assertions, removing redundant parentheses, updating lifetime annotations in trait implementations, and modernizing CI workflow steps.

  • Converted binary assertions (assert_eq!(…)) on booleans into assert!(…)
  • Removed unnecessary parentheses in slice copy operations
  • Updated CI configuration to use newer GitHub Actions versions and streamlined steps

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/null.rs Replaced assert_eq!(…, true) with assert!(…) for clarity
src/io.rs Removed redundant parentheses in slice copying operations
src/encode.rs Removed needless lifetime parameters and corrected doc comment history
src/decode.rs Removed needless lifetime parameters and updated doc comment history
src/combinator.rs Simplified assertions and use of is_some_and for readability
src/bytes.rs Removed redundant parentheses for cleaner slice copying operations
.github/workflows/ci.yml Updated checkout and toolchain installation steps and CI triggers
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:3

  • Verify that removing the pull_request trigger was intentional; if PR-based workflows are still desired, consider reintroducing the pull_request event.
on: [push]

Comment thread src/encode.rs
Comment thread src/decode.rs
@sile sile merged commit 86e1b57 into master May 5, 2025
9 checks passed
@sile sile deleted the fix-lint branch May 5, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants