Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several lint warnings by simplifying assertions, removing redundant parentheses, updating lifetime annotations in trait implementations, and modernizing CI workflow steps.
- Converted binary assertions (assert_eq!(…)) on booleans into assert!(…)
- Removed unnecessary parentheses in slice copy operations
- Updated CI configuration to use newer GitHub Actions versions and streamlined steps
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/null.rs | Replaced assert_eq!(…, true) with assert!(…) for clarity |
| src/io.rs | Removed redundant parentheses in slice copying operations |
| src/encode.rs | Removed needless lifetime parameters and corrected doc comment history |
| src/decode.rs | Removed needless lifetime parameters and updated doc comment history |
| src/combinator.rs | Simplified assertions and use of is_some_and for readability |
| src/bytes.rs | Removed redundant parentheses for cleaner slice copying operations |
| .github/workflows/ci.yml | Updated checkout and toolchain installation steps and CI triggers |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:3
- Verify that removing the pull_request trigger was intentional; if PR-based workflows are still desired, consider reintroducing the pull_request event.
on: [push]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.