Chore: Consolidate dependabot bumps (nuget-minor, actions/checkout, actions/cache, actions-minor)#1000
Chore: Consolidate dependabot bumps (nuget-minor, actions/checkout, actions/cache, actions-minor)#1000johnml1135 wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
eb24a4a to
a057467
Compare
|
Added breadcrumbs to the
No functional change — comment-only update to |
Combines 5 open dependabot PRs into one branch so they build and test together instead of as 5 separate merges: #997, #984, #982, #981, #980. Included bumps: - Microsoft.Build.Utilities.Core 18.6.3 -> 18.7.1 (+5 others) (#997) - nuget-minor group (10 updates): System.Drawing.Common, System.Reflection.Metadata, System.Resources.Extensions, System.Security.Permissions -> 9.0.17/10.0.9; SilLcm/SilLibPalaso version refresh in Build/SilVersions.props (#984) - actions/checkout 6 -> 7 across all workflow files (#982) - actions/cache 5 -> 6 in copilot-setup-steps.yml (#981) - actions-minor group: 2 SHA-pinned action bumps in CI.yml and base-installer-cd.yml (#980) Also pulls in #979's fix for RealDataTestsBase resolving its scratch project directory via a per-machine shared path, which collided across git worktrees and was needed to get a clean local test run. Holds Microsoft.Extensions.DependencyModel at 9.0.16 instead of the 9.0.17 that #984 proposed: Directory.Packages.props has a long-standing comment warning that bumping this package breaks ICU initialization in the .NET Framework test host, and the full local test suite reproduced that exact failure (TypeInitializationException on Icu.NativeMethods, FileLoadException loading Microsoft.Extensions.DependencyModel) until this one package was reverted. Every other package in that group is kept at its bumped version. Verified with build.ps1 -BuildTests (0 errors/warnings) and test.ps1 using the same TestFilter as CI.yml (4298 tests, only 12 failures, all pre-existing local RenderBaselineTests/RenderBenchmark pixel-diff mismatches unrelated to this change).
a057467 to
04a3756
Compare
|
Trimmed the `DependencyModel` comment - it had ballooned to 28 lines, way out of proportion with every other pin comment in this block (1-4 lines each). It now carries just the load-bearing facts (who wants what floor, the exact exception to grep for, a one-line retest procedure) and points back to this PR thread for the full investigation instead of duplicating it inline. While in there, also fixed two pre-existing stale comments unrelated to this pin but part of the same dependabot bump: `System.Drawing.Common` and `System.Security.Permissions` both said "Pin to 9.0.16" while actually pinned at 9.0.17. Amended into the same commit and force-pushed - still one commit, still gitlint-compliant. |
Summary
test together instead of as 5 separate merges: Chore: Bump Microsoft.Build.Utilities.Core and 5 others #997, Chore: Bump the nuget-minor group with 10 updates #984, Chore: Bump actions/checkout from 6 to 7 #982, Chore: Bump actions/cache from 5 to 6 #981, Chore: Bump the actions-minor group with 2 updates #980.
RealDataTestsBasecross-worktree collisions,which was needed to get a clean local CI run (see Test plan).
Microsoft.Extensions.DependencyModelat 9.0.16 instead of the9.0.17 that Chore: Bump the nuget-minor group with 10 updates #984's nuget-minor group proposed (see below).
Included dependabot bumps
System.Reflection.Metadata, System.Resources.Extensions,
System.Security.Permissions -> 9.0.17/10.0.9; SilLcm/SilLibPalaso version
refresh in
Build/SilVersions.propsCI.yml/base-installer-cd.yml)
Why Microsoft.Extensions.DependencyModel stays at 9.0.16
Directory.Packages.propshas carried a long-standing comment warningthat bumping this specific package breaks ICU initialization in the
.NET Framework test host. #984 bumped it to 9.0.17 anyway alongside the
other current-line packages. Running the full test suite locally
reproduced the exact failure the comment warns about:
5 test fixtures (
HCWorkerServiceTests,ToWordAnalysisDto_*) failedOneTimeSetUpuntil this was reverted back to 9.0.16. All otherpackage bumps from the nuget-minor group are kept. #984 is being
closed with an explanatory comment rather than merged as-is, since
dependabot bundles it as one grouped update.
Test plan
.\build.ps1 -Configuration Debug -BuildTests— 0 errors, 0 warnings.\test.ps1 -Configuration Debug -NoBuild -TestFilter 'TestCategory!=LongRunning&TestCategory!=ByHand&TestCategory!=SmokeTest&TestCategory!=DesktopRequired'(same filter as
.github/workflows/CI.yml) — 4298 tests, only 12failures, all pre-existing local
RenderBaselineTests/RenderBenchmarkpixel-diff mismatches (font/GPU renderingdifferences vs. the windows-2022 runner that captured the
baselines), unrelated to this branch's changes and previously
documented as a known local-environment gap.
🤖 Generated with Claude Code
This change is