Retire Linux-era view shims#906
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR retires legacy Linux/Mono-era managed Views shims (ViewInputManager, ManagedVwWindow) and updates code/docs/build plumbing to rely solely on the Windows-native Views input and geometry paths.
Changes:
- Removed managed shim projects/sources and related solution/build/reg-free manifest wiring.
- Simplified native Views codepaths to always use Windows-native
VwTextStore(input) andGetClientRect(geometry), eliminating COM activation branches. - Updated OpenSpec architecture docs/specs and change-tracking artifacts to reflect the shim retirement.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| openspec/specs/architecture/ui-framework/views-rendering.md | Updates architecture diagram text to reflect Windows-native input/geometry and shim retirement. |
| openspec/specs/architecture/interop/native-boundary.md | Updates interop boundary documentation to remove ManagedVwWindow as an active boundary. |
| openspec/specs/architecture/interop/com-contracts.md | Notes retired shims in COM contracts documentation. |
| openspec/changes/retire-linux-era-view-shims/** | Adds proposal/design/research/tasks and requirements specs for shim retirement and validation. |
| Src/views/VwRootBox.cpp | Removes non-Windows COM activation branch for ViewInputManager. |
| Src/views/VwSelection.cpp | Removes non-Windows IVwWindow wrapper path; always uses GetClientRect. |
| Src/views/VwTextStore.cpp | Removes non-Windows conditional around ClientToScreen / TSF-related behavior. |
| Src/views/Views.idh | Removes IVwWindow/VwWindow interface+coclass; adjusts IViewInputMgr comment. |
| Src/views/Views_GUIDs.cpp | Removes GUID exports for IVwWindow/VwWindow. |
| Src/Common/SimpleRootSite/ViewInputManager.cs | Deletes managed ViewInputManager shim. |
| Src/ManagedVwWindow/** | Deletes managed ManagedVwWindow project and its tests. |
| Build/RegFree.targets | Removes ManagedVwWindow.dll from managed COM manifest inputs. |
| Src/Common/FieldWorks/BuildInclude.targets | Removes ManagedVwWindow.dll from FieldWorks manifest inputs. |
| Build/mkall.targets | Removes excluded CLSIDs for the retired managed shims. |
| Build/Src/FwBuildTasks/CollectTargets.cs | Removes special-case Unix-only condition for ManagedVwWindow project. |
| FieldWorks.sln | Removes ManagedVwWindow projects from the solution. |
| .github/src-catalog.md | Removes catalog entry for ManagedVwWindow. |
NUnit Tests 1 files ±0 1 suites ±0 9m 25s ⏱️ - 1m 43s Results for commit 32dbddd. ± Comparison against base commit b0bf8a8. This pull request removes 2 tests. |
jasonleenaylor
approved these changes
May 21, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 20 files and all commit messages, and made 1 comment.
Reviewable status: 20 of 28 files reviewed, 4 unresolved discussions (waiting on johnml1135).
1 task
jasonleenaylor
added a commit
that referenced
this pull request
Jun 4, 2026
Add missing manifest files to RescuePatching target The base build 1437 (from release/9.3.9) still contains ManagedVwWindow.manifest and SimpleRootSite.manifest, which were removed on main by #906. The existing fix (#909) handled .dll, .dll.config, and .pdb but missed the two .manifest files, causing PYRO0305 errors during patch builds. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Jul 1, 2026
johnml1135
added a commit
that referenced
this pull request
Jul 6, 2026
- VersionInfoProvider: copyright year no longer freezes at whatever year the constant was last edited, ApplicationVersion resolves from the correct assembly instead of always falling back to the entry assembly, and MajorVersion/ParseInformationalVersion index defensively instead of assuming a fixed part count. Covered by new VersionInfoProviderTests.cs. - RegFree.targets: removes a dangling ManagedVwWindow.dll entry; the project was already retired in #904/#906, so the entry pointed at nothing. - opsx-*.prompt.md: replace inlined instructions with delegation to the existing .claude/skills/openspec-*/SKILL.md files, per this repo's skills-over-inline-prompts convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
johnml1135
added a commit
that referenced
this pull request
Jul 7, 2026
…d files ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
johnml1135
added a commit
that referenced
this pull request
Jul 7, 2026
ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ViewInputManagerandManagedVwWindow, including their solution and build wiringVwTextStore/IViewInputMgrand HWND client-rectangle geometry while removing staleIVwWindow/VwWindowinterop exposureValidation
./build.ps1./test.ps1 -SkipManaged -TestProject TestViews./test.ps1 -TestProject FwBuildTasksTests -TestFilter "FullyQualifiedName~RegFreeCreator"./test.ps1 -TestProject SimpleRootSiteTestsCI: Whitespace checkThis change is