Remove L10NSharp.Windows.Forms from LibChorus#388
Merged
Conversation
LibChorus does not use WinForms directly. The package was only supplying a transitive System.ServiceModel framework reference on net462. Add explicit framework references in LibChorus and ChorusHub instead. Co-authored-by: Cursor <cursoragent@cursor.com>
jasonleenaylor
approved these changes
Jul 6, 2026
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on hahn-kev).
imnasnainaec
approved these changes
Jul 6, 2026
imnasnainaec
left a comment
imnasnainaec
left a comment
Contributor
There was a problem hiding this comment.
@imnasnainaec reviewed all commit messages.
Reviewable status:
hahn-kev
enabled auto-merge (squash)
July 7, 2026 03:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
L10NSharp.Windows.Formspackage reference fromSIL.Chorus.LibChorusSystem.ServiceModelframework references fornet462in LibChorus and ChorusHub, replacing the transitive reference that the WinForms package was accidentally providingTest plan
dotnet build -c Releasesucceeds locallyThis change is