Skip to content

Use Node-standard corepack to install pnpm#76

Merged
rmunn merged 1 commit into
developfrom
chore/pnpm-via-corepack
May 25, 2023
Merged

Use Node-standard corepack to install pnpm#76
rmunn merged 1 commit into
developfrom
chore/pnpm-via-corepack

Conversation

@rmunn

@rmunn rmunn commented May 25, 2023

Copy link
Copy Markdown
Contributor

Will fix #75.

@rmunn

rmunn commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

Note that I'm not certain if corepack enable is the right command for dev machines. I think it is, since it certainly is the right command for the Dockerfile. But since I have pnpm already installed, I can't tell for certain that corepack enable is pulling in pnpm. Someone who does not have pnpm installed globally will need to test this and then verify that that's the right command as opposed to corepack prepare pnpm@latest --activate.

@rmunn
rmunn requested a review from hahn-kev May 25, 2023 02:26
@hahn-kev

Copy link
Copy Markdown
Collaborator

It looks good to me, I've already enabled corepack and installed pnpm with it, but running corepack enable now doesn't break anything, so I'm fine to merge it in and see what issues we run into.

@rmunn
rmunn merged commit c24da0f into develop May 25, 2023
@rmunn
rmunn deleted the chore/pnpm-via-corepack branch May 25, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specify PNPM in package.json via corepack

2 participants