Strict parsing #2

[Enkidu93]

This change is 

[johnml1135]

The build is broken - let's fix that first.

[johnml1135]

src/SIL.Machine.AspNetCore/Services/SmtTransferEngineBuildJob.cs line 62 at r1 (raw file):

            try
            {
                useStrictParsing = bool.Parse((string?)buildOptionsObject?["useStrictParsing"] ?? "false");

So, strict parsing is false by default. Is that the desire as per Damien?

[Enkidu93]

The build is broken - let's fix that first.

That's because it requires the build_options update to Serval. It's not broken in and of itself. You can verify this locally.

[Enkidu93]

src/SIL.Machine.AspNetCore/Services/SmtTransferEngineBuildJob.cs line 62 at r1 (raw file):

            try
            {
                useStrictParsing = bool.Parse((string?)buildOptionsObject?["useStrictParsing"] ?? "false");

So, strict parsing is false by default. Is that the desire as per Damien?

As I understood it...See this connected comment.

[johnml1135]

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

[johnml1135]

src/SIL.Machine.AspNetCore/Services/SmtTransferEngineBuildJob.cs line 62 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

As I understood it...See this connected comment.

ok. Makes sense. See comment in Serval about adding swagger docs about this.

[johnml1135]

Reviewed 15 of 15 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

[ddaspit]

Reviewed 2 of 14 files at r1, 15 of 15 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)