Update field names to be consistent with FLEx - #1731
Merged
Conversation
longrunningprocess
enabled auto-merge (squash)
February 16, 2023 20:17
longrunningprocess
marked this pull request as draft
February 22, 2023 15:02
auto-merge was automatically disabled
February 22, 2023 15:02
Pull request was converted to draft
Contributor
Author
|
moved to draft because we received more info from the requestor on fields, we'll need to do a little more work once final decisions are made... |
longrunningprocess
changed the title
longrunningprocess
marked this pull request as ready for review
February 23, 2023 20:01
longrunningprocess
enabled auto-merge (squash)
February 23, 2023 20:09
megahirt
reviewed
Feb 24, 2023
megahirt
approved these changes
Feb 24, 2023
megahirt
left a comment
megahirt
left a comment
Collaborator
There was a problem hiding this comment.
Other than verifying what "Sense Type" field label is used in FLEx, I approve of this PR. Thanks! This PR should match what FLEx has as far as field labels go.
longrunningprocess
pushed a commit
that referenced
this pull request
May 23, 2023
This reverts commit 3927735.
longrunningprocess
pushed a commit
that referenced
this pull request
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1730
Description
Checklist
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.