Skip to content

SF-3822 Allow drafting any book that is present in the source#3965

Merged
RaymondLuong3 merged 2 commits into
masterfrom
feature/sf-3822-draft-missing-books
Jun 26, 2026
Merged

SF-3822 Allow drafting any book that is present in the source#3965
RaymondLuong3 merged 2 commits into
masterfrom
feature/sf-3822-draft-missing-books

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This PR allows users to select any book for drafting that is present in the drafting source. Previous work has enabled books not currently present in the target project to be visible to previous formatting and view in the editor.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added will require testing PR should not be merged until testers confirm testing is complete e2e Run e2e tests for this pull request labels Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.03%. Comparing base (2ab127c) to head (b6c6230).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...neration-steps/draft-generation-steps.component.ts 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
- Coverage   81.04%   81.03%   -0.01%     
==========================================
  Files         638      638              
  Lines       41160    41165       +5     
  Branches     6695     6695              
==========================================
+ Hits        33357    33360       +3     
- Misses       6766     6768       +2     
  Partials     1037     1037              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-assigned this Jun 24, 2026
@pmachapman
pmachapman self-requested a review June 24, 2026 02:47

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: It works well.

I notice that I get a message if I open the draft tab saying I don't have permission to import, even though I am admin. This is a bug that pre-dates your PR, so I wouldn't classify this as a blocker to this PR, but just in case this was something you are aware of? The import wizard works fine.

image.png

@pmachapman reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jun 24, 2026
@RaymondLuong3 RaymondLuong3 added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed e2e Run e2e tests for this pull request ready to test labels Jun 26, 2026
@RaymondLuong3
RaymondLuong3 force-pushed the feature/sf-3822-draft-missing-books branch from bcef586 to b6c6230 Compare June 26, 2026 15:18
@RaymondLuong3
RaymondLuong3 merged commit f7e7ed2 into master Jun 26, 2026
26 checks passed
@RaymondLuong3
RaymondLuong3 deleted the feature/sf-3822-draft-missing-books branch June 26, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants