Removing admin site from urls.py#678
Closed
adamcharnock wants to merge 1 commit intosilverapp:masterfrom
Closed
Conversation
I'm removing this as I *believe* the admin URLs should really be added by the host
django project. Adding the urls in the host project *and* in silver triggers the
following django warning:
?: (urls.W005) URL namespace 'admin' isn't unique. You may not be able to reverse all URLs in this namespace
I therefore propose it's removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm removing this as I believe the admin URLs should really be added by the host
django project. Adding the urls in the host project and in silver triggers the
following django warning:
I therefore propose it's removal
Note I haven't been able to run the tests for this change I applied it to the current master stripe code, rather than applying it on top of the changes in #677