Skip to content

insert_all(..., alter=True) should work for new columns introduced after the first 100 records - #142

Merged
simonw merged 5 commits into
simonw:mainfrom
simonwiles:always-check-columns
Aug 28, 2020
Merged

insert_all(..., alter=True) should work for new columns introduced after the first 100 records#142
simonw merged 5 commits into
simonw:mainfrom
simonwiles:always-check-columns

Conversation

@simonwiles

Copy link
Copy Markdown
Contributor

Closes #139.

@simonw

simonw commented Aug 28, 2020

Copy link
Copy Markdown
Owner

Thanks very much!

@simonw

simonw commented Aug 28, 2020

Copy link
Copy Markdown
Owner

Looks like it failed the "black" formatting test - possibly because there's a new release if black out. I'm going to merge despite that failure.

@simonw

simonw commented Aug 28, 2020

Copy link
Copy Markdown
Owner

Yeah I think that failure is actually because there's a brand new release of Black out and it subtly changes some of the formatting rules. I'll merge this and then run Black against the entire codebase.

@simonw
simonw merged commit 947bb76 into simonw:main Aug 28, 2020
simonw added a commit that referenced this pull request Aug 28, 2020
simonw added a commit that referenced this pull request Aug 28, 2020
@simonwiles
simonwiles deleted the always-check-columns branch August 30, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

insert_all(..., alter=True) should work for new columns introduced after the first 100 records

2 participants