Fix PHP Warning: Trying to access array offset on null#78
Merged
restena-sw merged 1 commit intosimplesamlphp:masterfrom May 5, 2025
Merged
Fix PHP Warning: Trying to access array offset on null#78restena-sw merged 1 commit intosimplesamlphp:masterfrom
restena-sw merged 1 commit intosimplesamlphp:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
=========================================
Coverage 10.48% 10.48%
- Complexity 324 325 +1
=========================================
Files 17 17
Lines 1259 1259
=========================================
Hits 132 132
Misses 1127 1127 🚀 New features to boost your workflow:
|
Collaborator
|
Indeed, "rk" is the only credential property extension defined in the webauthn-2 spec: https://www.w3.org/TR/webauthn-2/#sctn-authenticator-credential-properties-extension It's safe to be more specific in the array check as suggested by the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm assuming the array key doesn't exist when not using a resident key