Skip to content

postgres: print sql errors and exceptions details #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spaced4ndy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

postgres: print sql errors and exceptions details #1592

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b51969c
postgres: print sql errors and exceptions details
spaced4ndy Jul 25, 2025
a678758
don't catch sql error second time
spaced4ndy Jul 25, 2025
3d2bf6c
comment
spaced4ndy Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't catch sql error second time
  • Loading branch information
@spaced4ndy
spaced4ndy committed Jul 25, 2025
commit a678758de8d32d24bfa6190b190c90af12794e72
8 changes: 6 additions & 2 deletions src/Simplex/Messaging/Agent/Store/Postgres/DB.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ module Simplex.Messaging.Agent.Store.Postgres.DB
)
where

import Control.Exception (catch)
import qualified Control.Exception as E
import Control.Monad (void)
import Data.ByteString.Char8 (ByteString)
Expand Down Expand Up @@ -68,7 +67,12 @@ withLoggedErrors :: Show q => q -> IO a -> IO a
withLoggedErrors q action =
action
`E.catch` (\(e :: SqlError) -> logSqlErrorAndRethrow e)
`E.catch` (\(e :: E.SomeException) -> logGenericErrorAndRethrow e)
`E.catch`
(\(e :: E.SomeException) ->
case E.fromException e :: Maybe SqlError of
Just sqlErr -> E.throwIO sqlErr -- rethrow SqlError without logging
Nothing -> logGenericErrorAndRethrow e
)
where
logSqlErrorAndRethrow :: SqlError -> IO a
logSqlErrorAndRethrow e = do
Expand Down
Loading