Skip to content

fix: pin Quartz cron triggers to UTC instead of the server's local ti… - #53

Merged
hamzahalq merged 1 commit into
mainfrom
hamza/cron-utc-timezone
Jul 22, 2026
Merged

fix: pin Quartz cron triggers to UTC instead of the server's local ti…#53
hamzahalq merged 1 commit into
mainfrom
hamza/cron-utc-timezone

Conversation

@hamzahalq

Copy link
Copy Markdown
Contributor

…mezone

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

UTC cron scheduling

Layer / File(s) Summary
UTC timezone on trigger creation
SW.Scheduler/ScheduleRepository.cs, SW.Scheduler/SchedulerPreparation.cs
Cron triggers created by schedule registration, conditional scheduling, and cleanup registration now explicitly use TimeZoneInfo.Utc while preserving misfire settings.
UTC timezone on trigger replacement
SW.Scheduler/ScheduleRepository.cs, SW.Scheduler/QuartzSchedulerViewerCommand.cs
Cron triggers rebuilt or recreated during rescheduling now explicitly use TimeZoneInfo.Utc; other lookup, validation, and rescheduling logic is unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: risk:medium

Suggested reviewers: mmalkhatib

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is too truncated to convey meaningful change details, though it appears related to the timezone update. Provide a complete description of the UTC timezone change and its impact on Quartz cron trigger behavior.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: forcing Quartz cron triggers to use UTC instead of the server timezone.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hamzahalq
hamzahalq merged commit c8cd245 into main Jul 22, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants