Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • added block name to error notifications

Type of Change

  • New Feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 19, 2026 5:49pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 19, 2026

Greptile Summary

Enhanced error notifications by prefixing them with the block name where the error occurred, improving error identification and debugging.

  • Modified error notification message format from just the error message to ${blockName}: ${errorMessage}
  • Uses fallback value 'Unknown Block' when blockName is not available
  • Maintains existing copilot action message format with block context
  • No changes to error handling logic or notification behavior

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is minimal, well-contained, and improves user experience by adding context to error messages. The implementation correctly handles the case where blockName might be undefined by using a fallback value, and all call sites in the codebase consistently provide blockName when calling addConsole.
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/stores/terminal/console/store.ts Added block name prefix to error notification messages for better context

Sequence Diagram

sequenceDiagram
    participant WE as Workflow Execution
    participant TCS as TerminalConsoleStore
    participant NS as NotificationStore
    participant UI as User Interface
    
    WE->>TCS: addConsole(entry with error)
    TCS->>TCS: Create console entry with UUID
    TCS->>TCS: Check if entry.error exists
    alt Error exists and notifications enabled
        TCS->>TCS: Extract errorMessage = String(error)
        TCS->>TCS: Extract blockName or use 'Unknown Block'
        TCS->>TCS: Format displayMessage = `${blockName}: ${errorMessage}`
        TCS->>TCS: Format copilotMessage with context
        TCS->>NS: addNotification(displayMessage, copilot action)
        NS->>UI: Show error notification with block name
    end
    TCS-->>WE: Return new console entry
Loading

@waleedlatif1 waleedlatif1 merged commit 408597e into staging Jan 19, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/google-docs branch January 19, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants