-
Notifications
You must be signed in to change notification settings - Fork 12
Update v3.md #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sonnymorgan-cell
wants to merge
1
commit into
simwood:master
Choose a base branch
from
sonnymorgan-cell:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update v3.md #31
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2946,10 +2946,13 @@ Each port will be one of the following types, if unsure please contact the LCP b | |
| The above is provided for guidance only, the Number Portability Guide should be consulted to determine lead times for porting requests. | ||
|
|
||
| #### Number Object | ||
| The ‘numbers' array in the above should be an array of objects each with the following structure. These must include all numbers, including the MBN (even though it is specified separately) | ||
| The ‘numbers' array in the above should be an array of objects each with the following structure. These must include all numbers, including the MBN (even though it is specified separately). | ||
|
|
||
| Where a Multi/MultiLine port is submitted and the associated numbers are a specific range, rather than individual numbers, a RangeId must be specified against all of the numbers in the range, any additional associated numbers that are not part of the range, should have the value "Null". A RangeId parameter is not required if there is not an associated range. | ||
|
|
||
| |Parameter|Values|| | ||
| |:-|-|-| | ||
| |**rangeId**|Null <br/>1 <br/>2 | | ||
| |**number**|01xxxxxxxxx <br/>02xxxxxxxxx |Number in UK National format | | ||
| |**type**| mbn |Main Billing Number (must only be one of this type) | ||
| ||associated| Associated Number (e.g. another DDI on an ISDN circuit)| | ||
|
|
@@ -3052,14 +3055,14 @@ or Name (e.g. 104, The Lighthouse, Thatched Cottage)</td> | |
| "postcode": "A12 3BC" | ||
| }, | ||
| "numbers": [ | ||
| {"number": "01632960100", "type": "mbn", "action": "port"}, | ||
| {"number": "01632960101", "type": "associated", "action": "port"}, | ||
| {"number": "01632960102", "type": "associated", "action": "port"}, | ||
| {"number": "01632960103", "type": "associated", "action": "port"}, | ||
| {"number": "01632960104", "type": "associated", "action": "port"}, | ||
| {"number": "01632960105", "type": "associated", "action": "port"}, | ||
| {"number": "01632960106", "type": "associated", "action": "port"}, | ||
| {"number": "01632960290", "type": "other", "action": "retain"} | ||
| {"rangeId":null,"number": "01632960100", "type": "mbn", "action": "port"}, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor formatting issue - indentation - a space has been removed |
||
| {"rangeId":1,"number": "01632960101", "type": "associated", "action": "port"}, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor formatting issue - spaces, should be like:
|
||
| {"rangeId":1,"number": "01632960102", "type": "associated", "action": "port"}, | ||
| {"rangeId":1,"number": "01632960103", "type": "associated", "action": "port"}, | ||
| {"rangeId":1,"number": "01632960104", "type": "associated", "action": "port"}, | ||
| {"rangeId":1,"number": "01632960105", "type": "associated", "action": "port"}, | ||
| {"rangeId":1,"number": "01632960106", "type": "associated", "action": "port"}, | ||
| {"rangeId":null,"number": "01632960290", "type": "other", "action": "retain"} | ||
| ] | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how this line renders, I suspect not quite what you were expecting?
BTW if you want to preview your changes, you can run a local dev server. Install Homebrew, then run
brew install yarn, then from the repo root runyarnto install dependencies andyarn startto launch a local dev server at http://localhost:3000/ where you can preview your changes live :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how I wanted this to render, as I wanted to list options showing that you could add multiple different ranges, similar to how the different numbers are listed.