Skip to content

[Carry #1307] sinatra-contrib README: Fix links#1394

Merged
namusyaka merged 4 commits intosinatra:masterfrom
olleolleolle:fix/carry-1307
Feb 20, 2018
Merged

[Carry #1307] sinatra-contrib README: Fix links#1394
namusyaka merged 4 commits intosinatra:masterfrom
olleolleolle:fix/carry-1307

Conversation

@olleolleolle
Copy link
Copy Markdown
Member

@olleolleolle olleolleolle commented Feb 20, 2018

Closes #1307.

mediafinger and others added 4 commits June 8, 2017 11:33
The links have been broken. They now point to:
`http://www.sinatrarb.com/contrib/[topic]`

As `test-helpers` and `engine-tracking` are not part of the contrib project, they point to:
`http://www.rubydoc.info/github/sinatra/sinatra-contrib/Sinatra/[topic]`
  - relates to test helpers, engine tracking
  - see sinatra#1307
@olleolleolle
Copy link
Copy Markdown
Member Author

@namusyaka There, I carried the changes in this PR.

@namusyaka namusyaka added this to the v2.0.2 milestone Feb 20, 2018
@namusyaka namusyaka self-requested a review February 20, 2018 13:09
Copy link
Copy Markdown
Member

@namusyaka namusyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@namusyaka namusyaka merged commit 299961d into sinatra:master Feb 20, 2018
@olleolleolle olleolleolle deleted the fix/carry-1307 branch February 20, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants