feat: add .getAll() to get all config items#198
Closed
wy-luke wants to merge 8 commits intosindresorhus:mainfrom
wy-luke:main
Closed
feat: add .getAll() to get all config items#198wy-luke wants to merge 8 commits intosindresorhus:mainfrom wy-luke:main
.getAll() to get all config items#198wy-luke wants to merge 8 commits intosindresorhus:mainfrom
wy-luke:main
Conversation
Owner
|
This should be a separate method. |
Author
|
@sindresorhus How about this: 7019c7c |
get to return entire store when no key is provided.getAll() to get all entire items
.getAll() to get all entire items.getAll() to get all entire items
.getAll() to get all entire items.getAll() to get all config items
Owner
|
Needs a test. |
Author
|
@sindresorhus All done. Take a look plz. |
Owner
|
I just realized, this already exists as |
Author
I think But still, it's up to you. ❤️ |
Owner
No, it always returns an object. |
Owner
|
I think |
Author
|
@sindresorhus At least, adding this usage to the Readme is necessary. It's easy to use but too hard to know it, even you realize its existence later. 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assuming that I have a config like below:
{ "a": "a", "b": "b", "c": "c", "d": "d" }To get all configs, I must use
get(xx)four times. I think maybe it's a good idea to useget()to retrieve all configs at one time.When using
electron, it can also get all configs with only one disk IO.