TDL-22921 Fix the api limit error#190
Merged
Merged
Conversation
…ed in header - X-RateLimit-Remaining
vishalp-dev
approved these changes
May 15, 2023
AJWurts
pushed a commit
to villagelabsco/tap-github
that referenced
this pull request
Oct 24, 2024
* to avoid api rate limit error, tap will sleep for the seconds mentioned in header - X-RateLimit-Remaining * recursively call the function(afterwards) if the tap is paused for sometime. * fix the existing unit tests * fixed pylint issue * update comments * setup and changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
GitHub has a 5000 API requests limit per hour, once the API request rate limit is reached the TAP throws the below exception -
To resolve the issue, make the tap sleep for
X-RateLimit-Reset+2(buffer) and recursively call theauth_getfunction to continue the execution.Remove the config property -
max_sleep_secondsas it does not add any significance within the code. (These property is already missing from the connection service platform integration properties table.)Manual QA steps
Risks
Rollback steps