SAC-30973: Exclude un-auth streams - #91
Open
satyendra101 wants to merge 8 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the tap’s discovery/catalog generation so that streams which are inaccessible with the provided credentials are detected early (via lightweight endpoint probes) and excluded from the discovered catalog. It also ensures credentials are verified at startup by using IntercomClient as a context manager, and adds unit tests around the new behavior.
Changes:
- Add per-stream accessibility probing during schema creation and exclude unauthorized/inaccessible streams from the catalog.
- Verify credentials on startup by wrapping tap execution in
with IntercomClient(...) as client:. - Add probe configuration for POST-based streams and introduce unit tests for stream probing and pruning behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unittests/test_schema.py | Adds unit tests for probing/access checks, pruning inaccessible child streams, and catalog filtering. |
| tests/unittests/test_init.py | Updates init tests to account for IntercomClient context manager usage and new discover signature. |
| tap_intercom/streams.py | Adds probe metadata (probe_http_method, probe_search_query) for POST-search based streams. |
| tap_intercom/schema.py | Implements stream probing, inaccessible stream filtering, and child-pruning during schema discovery. |
| tap_intercom/discover.py | Changes discover() to accept an IntercomClient and pass it into get_schemas(). |
| tap_intercom/client.py | Adds probe_stream() helper for GET/POST probing. |
| tap_intercom/init.py | Wraps main execution in IntercomClient context manager and threads client into discovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MuralidharT03
requested changes
Jun 8, 2026
MuralidharT03
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
JIRA: https://qlik-dev.atlassian.net/browse/SAC-30973
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code