Add support for guessing version numbers to CLI invocations#467
Merged
siom79 merged 2 commits intosiom79:masterfrom Nov 23, 2025
Merged
Add support for guessing version numbers to CLI invocations#467siom79 merged 2 commits intosiom79:masterfrom
siom79 merged 2 commits intosiom79:masterfrom
Conversation
Moved the guessVersion method from the maven plug-in to the core japicmp and use it to guess version of jars when using CLI
This was referenced Nov 18, 2025
Owner
|
Thank you for the PR and work. |
Optional.isEmpty was introduced in Java 11 and the code needs to operate on Java 8 still, including the tests.
Contributor
Author
|
Thanks @siom79 for the initial review. I have corrected the use of Java 11 API in the test. |
Owner
|
Released with 0.25.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the guessVersion method from the maven plug-in to the core japicmp and use it to guess version of jars when using CLI
I was trying to use
--error-on-semantic-incompatibilityfrom the CLI, but because there seems to be no way to pass version numbers in to the CLI for new and old jars I put together this PR in the hope this is a reasonable way to achieve what I am looking to do.