Skip to content

testing: fix usage of the Testify API#1427

Merged
thaJeztah merged 1 commit intosirupsen:masterfrom
dolmen:fix-testify-usage
Aug 4, 2025
Merged

testing: fix usage of the Testify API#1427
thaJeztah merged 1 commit intosirupsen:masterfrom
dolmen:fix-testify-usage

Conversation

@dolmen
Copy link
Contributor

@dolmen dolmen commented Mar 12, 2024

Fix incorrect usages of the Testify API, thanks to testifylint running via golangci-lint.

Notes:

  • Thoses issues are not raised in CI because golangci-lint is disabled for tests' sources. Of course we must fix issues first before enabling golangci-lint for tests
  • I'm a Testify co-maintainer

Fix incorrect usages of the Testify API, thanks to testifylint.

Note: I'm a Testify co-maintainer
@dolmen dolmen force-pushed the fix-testify-usage branch from 1718cbc to 83d711d Compare March 12, 2024 14:34
Copy link
Collaborator

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit d916819 into sirupsen:master Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants