Change key structure of the page URL sent to Graphite

[soulgalore]

To make those calculations easier per-site-per-page I would suggest I slightly different metric naming send to Graphite for "per page" metrics: I would suggest the following segments: protocol.hostname.pathname (changing dots to underscore for hostname). This way all urls would have the same four metric pieces. Would make templating in Grafana allot easier as well.
@JeroenVdb

Yes good idea, lets fix this!

[JeroenVdb]

@soulgalore hadn't had time for a thorough test but I saw that the dots in hostname aren't replaced by underscore as I suggested? I would suggest this so all base urls heb the same metric length:

http://www.demorgen.be/
http://www.demorgen.co.uk/

http.www_demorgen_be.slash (4)
http.www_demorgen_co_uk.slash (4)

# instead of 
http.www.demorgen.be.slash (5)
http.www.demorgen.co.uk.slash (6)

[soulgalore]

hmm they should be, then there must be a miss or a missunderstanding. let me check later when I'm online. I think they are changed for each individual request but you mean for the full path right, could probably be that I missed that. I need to cleanup the code of generating the keys so it don't get messier.

best
Peter

[JeroenVdb]

Yes I see the that for the request hostname and path the dots are changed. But not for the "base" url.

sitespeed.all.ads.http.**www.demorgen.be**.slash.requests.http.**www_demorgen_be**._photo_bayern-vermorzelt-porto-in-weergaloze-ode-aan-totaalvoetbal_ZjUwOS9hdC83NjUxOTY2LzI2N3gxMzkvRkw_267x139_7651966_jpg.timings.receive 2 1429708965

[soulgalore]

yep I missed that, looking forward to 3.5 the next coming days then. Its an easy fix but I need to add some test cases so I can verify the key structure.

[JeroenVdb]

Great! Allot of progress lately! Very nice!

[soulgalore]

@JeroenVdb I've fixed it in the master branch yesterday, any chance you can have a look/test before I do the release?

Best
Peter

[JeroenVdb]

Looks great!

trash.http.www_demorgen_be._binnenland_grondwettelijk-hof-verwerpt-beroep-tot-vernietiging-gas-wet-a2296743_.requests.http.static3_demorgen-cdn_be._photo_-_NTRjYi90cy83NjU1NzUwLzMwMHgyOTAvRkw_300x290_7655750_jpg.timings.

[soulgalore]

thanks for veryfing!