feat: Phase 4 - Extended function support#20
Merged
Conversation
Add SQL rewriter rules to map Snowflake function names to DataFusion equivalents: CURRENT_TIMESTAMP->now(), TRUNCATE->trunc, CEILING->ceil, POW->power, LEN->length, IFNULL->NVL, ZEROIFNULL->COALESCE, NULLIFZERO->NULLIF
…ME functions - TO_DATE: convert string to date with auto format detection - TO_TIMESTAMP: convert string to timestamp - LAST_DAY: return last day of month - DAYNAME: return weekday name (Mon, Tue, etc.) - MONTHNAME: return month name (Jan, Feb, etc.)
- DIV0: returns 0 when dividing by zero - DIV0NULL: returns NULL when dividing by zero
- SHA1: returns 40-char hex SHA-1 hash - SHA2: returns SHA-2 hash with configurable bit length (224, 256, 384, 512)
Add Snowflake-compatible context functions that return emulator defaults: - CURRENT_USER() -> EMULATOR_USER - CURRENT_ROLE() -> ACCOUNTADMIN - CURRENT_DATABASE() -> EMULATOR_DB - CURRENT_SCHEMA() -> PUBLIC - CURRENT_WAREHOUSE() -> EMULATOR_WH
Add Go integration tests for Phase 4 functions: - Date/Time: TO_DATE, LAST_DAY, DAYNAME, MONTHNAME - Numeric: DIV0, DIV0NULL - Hash: SHA1, SHA2 - Context: CURRENT_USER, CURRENT_ROLE, CURRENT_DATABASE, CURRENT_SCHEMA, CURRENT_WAREHOUSE - SQL Rewriter: CURRENT_TIMESTAMP, LEN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan