Skip to content

Solve issue #28 caused by Cache::Memcached::get_multi #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadam merged 2 commits into from
Apr 8, 2025
Merged

Solve issue #28 caused by Cache::Memcached::get_multi #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90097e9
Merge pull request #1 from sixapart/master
sewi-cpan May 24, 2019
d09d0a9
Solved: Cache::Memcached rarly returns keys different to requested ones
sewi-cpan May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions lib/Data/ObjectDriver/Driver/BaseCache.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,6 @@ sub lookup_multi {
my %id2key = map { $_ => $driver->cache_key($class, $_) } grep { defined } @$ids;
my $got = $driver->get_multi_from_cache(values %id2key);

## If we got back all of the objects from the cache, return immediately.
if (scalar keys %$got == @$ids) {
my @objs;
for my $id (@$ids) {
my $obj = $driver->inflate($class, $got->{ $id2key{$id} });
$obj->{__cached}{ref $driver} = 1;
push @objs, $obj;
}
return \@objs;
}

## Otherwise, look through the list of IDs to see what we're missing,
## and fall back to the backend to look up those objects.
my($i, @got, @need, %need2got) = (0);
Expand Down