feat: add --no-color flag with NO_COLOR env and auto-disable on non-TTY#16
Merged
Conversation
…non-TTY Disable ANSI color codes in output when: - --no-color flag is set - NO_COLOR environment variable is set (https://no-color.org/) - stdout is not a TTY (piping/redirect) Converts color constants to variables with a DisableColors() function. Includes unit test, E2E tests, and updates to SPEC.md and ROADMAP.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-colorCLI flag to disable ANSI color codes in outputNO_COLORenvironment variable (no-color.org standard)Changes
internal/display/colors.goconst→var, addedDisableColors()internal/display/colors_test.goDisableColors()cmd/clitest/root.go--no-colorflag,NO_COLORenv check, non-TTY detectiontest/e2e/options/it_disables_color_with_no_color_flag.clitestSPEC.md--no-colorflagROADMAP.mdTesting
make allpasses — unit tests, lint, E2E, and examples all green.