Skip to content

Fix #2890 #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
l0gicgate merged 1 commit into from
Dec 25, 2019
Merged

Fix #2890 #2906

l0gicgate merged 1 commit into from
Dec 25, 2019

Conversation

@t0mmy742
Copy link
Contributor

@t0mmy742 t0mmy742 commented Dec 24, 2019 •
edited by l0gicgate
Loading

Closes #2890

@coveralls
Copy link

coveralls commented Dec 24, 2019

Coverage Status

Coverage remained the same at 98.052% when pulling a98d755 on t0mmy742:fix2890 into 1c9318a on slimphp:3.x.

l0gicgate
l0gicgate reviewed Dec 25, 2019
View reviewed changes
@l0gicgate l0gicgate added this to the 3.12.4 milestone Dec 25, 2019
@l0gicgate l0gicgate merged commit 5ca71b9 into slimphp:3.x Dec 25, 2019
@t0mmy742 t0mmy742 deleted the fix2890 branch December 26, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

+1 more reviewer

@jacekkarczmarczyk jacekkarczmarczyk jacekkarczmarczyk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Slim 3

Projects

None yet

Milestone

3.12.4

Development

Successfully merging this pull request may close these issues.

4 participants

@t0mmy742 @coveralls @l0gicgate @jacekkarczmarczyk