Skip to content

Conversation

@t0mmy742
Copy link
Contributor

@t0mmy742 t0mmy742 commented Nov 4, 2021

I still need to add some unit tests before merging.

@coveralls
Copy link

coveralls commented Nov 4, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 110d76d on t0mmy742:phpstan_v1 into a8e4ce9 on slimphp:4.x.

@l0gicgate
Copy link
Member

Thank you for this contribution @t0mmy742

We should add tests for the newly introduced if cases where we throw the exceptions before merging so we keep coverage at 100%

@t0mmy742
Copy link
Contributor Author

t0mmy742 commented Nov 4, 2021

@l0gicgate Yes, I planned to send a commit tomorrow 👍

@t0mmy742
Copy link
Contributor Author

t0mmy742 commented Nov 5, 2021

Tests added. PR ready !

@l0gicgate l0gicgate added this to the 4.10.0 milestone Nov 7, 2021
@l0gicgate l0gicgate merged commit e208383 into slimphp:4.x Nov 7, 2021
chriscct7 pushed a commit to awesomemotive/aioseo-slim-v3-php-8.1 that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants